On Wed, Apr 6, 2016 at 11:40 PM, Santiago Torres <santi...@nyu.edu> wrote: >> > v5 (this): >> > Added helpful feedback by Eric >> > >> > * Reordering of the patches, to avoid temporal inclusion of a regression >> > * Fix typos here and there. >> > * Review commit messages, as some weren't representative of what the >> > patches >> > were doing anymore. >> > * Updated t7030 to include Peff's suggestion, and added a helped-by line >> > here >> > as it was mostly Peff's code. >> > * Updated the error-handling/printing issues that were introduced when. >> > libifying the verify_tag function. >> >> This version is a more pleasant read, easier to digest and understand. >> All of my review comments were minor; nothing demanding a re-roll. As >> such, this version is: >> >> Reviewed-by: Eric Sunshine <sunsh...@sunshineco.com> >> >> If you do happen to re-roll based upon the review comments, feel free >> to add my Reviewed-by: (but not if you make larger changes). > > Thanks! I'll add your and Junio's in another re-roll.
I don't think Junio explicitly gave his Reviewed-by: (indicating his approval of the patches as-is), so you wouldn't want to include his Reviewed-by:. If you make any changes beyond the minor ones mentioned in my reviews or beyond plagiarizing commit message enhancements offered by my or Junio's reviews, then you'd also probably want to hold off adding my Reviewed-by: since I wouldn't yet have reviewed whatever new changes you're making. (And, if you do make changes beyond ones I mentioned, and if I review them and consider them issue-free, I can always re-extend my Reviewed-by:.) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
