On Tue, Mar 8, 2016 at 7:25 PM, Moritz Neeb <li...@moritzneeb.de> wrote: > how to deal with patches during the v2.8.0 rc freeze? Will they wait on > the mailing list until the feature release cycle is finished? > > Or if it's me who should act on this series, because it got below the > radar during the rc freeze? > > To my knowledge there's only minor points that have to be discussed: > > in patches 4/7 and 5/7: Which commit should remove the trimming of > "split[0]", cf.: > > > http://thread.gmane.org/gmane.comp.version-control.git/285118/focus=287894
The reason I brought the issue up in review is that it wasn't clear if dropping the rtrims over the course of two patches was intentional or just an oversight (given that the review recommendation from the previous round had suggested removing both in the same patch). From your response, it is clear that it was intentional and, as mentioned in the cited messages, while I do have an opinion on the matter, it's such a minor point that it's not worth a lot of back and forth, and the patch can move forward if you're happy with it the way it is. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
