Junio C Hamano <gits...@pobox.com> writes: > Nah, I think you just misspelt hashcpy() as hashcmp(). The original > wanted to get the binary representation of the hex in old_sha1 when > it continued, and you wanted to delay the touching of old_sha1 until > we make sure that the input is valid 40-hex.
That much was correct, but... > , so something like this > is what Gabriel wants to do (which I agree with), isn't it? ... definitely not that X-<. The "do this or fail || do that or fail || ..." chain in the if condition part confused me. I think Gabriel's patch is exactly what we want. Sorry for starting a review before caffeine ;-) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
