On Thu, 2016-02-11 at 11:03 +0100, Michael Haggerty wrote: > On 02/05/2016 08:44 PM, David Turner wrote: > > The refs infrastructure learns about log-only ref updates, which > > only > > update the reflog. Later, we will use this to separate symbolic > > reference resolution from ref updating. > > This looks good. I assume it will get some testing later in the > series.
The existing tests cover this pretty well, I think. It's not intended to have user-visible results, so it's hard to specifically test. > > [...] > > diff --git a/refs/refs-internal.h b/refs/refs-internal.h > > index fc5d1db..b5d0ab8 100644 > > --- a/refs/refs-internal.h > > +++ b/refs/refs-internal.h > > @@ -42,6 +42,8 @@ > > * value to ref_update::flags > > */ > > > > +#define REF_LOG_ONLY 0x80 > > + > > Please add a comment explaining the meaning/purpose of this flag. Commented, thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
