Stefan Beller <sbel...@google.com> writes: > I am sending out a new version for replacing sb/submodule-parallel-fetch for > the time after the 2.7 release. > > * Dropped the patch, which introduces xread_nonblock > * strbuf_read_once uses xread now. This is safe as we poll before using > strbuf_read_once, so we know we won't stall.
"That is only true for the current callers" was my first reaction, but it is safe and sensible even for future callers. If they have something better to do than getting stuck before reading some, they ought to be checking for POLLIN before calling this, and if not, they do not have to be forced to spin for themselves until this returns some new payload. I like that. > * have the commit message reworded for "run-command: add an > asynchronous parallel child processor" with Johannes' suggestion. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
