On Mon, Dec 7, 2015 at 7:54 PM, Junio C Hamano <gits...@pobox.com> wrote: > Nguyễn Thái Ngọc Duy <pclo...@gmail.com> writes: > >> Let's hope there will be no third report about this commit.. > > Hmm, why does this additional test fail only under prove but pass > without it?
It passes with prove for me. Some mysterious variable leaks through somehow? >> + env | grep GIT_ | sed "s/=.*//" | sort >actual > > This is more about coding discipline than style, but piping grep > output to sed is wasteful. "sed -ne '/^GIT_/s/=.*//p'" or something > like that, perhaps? OK will fix. > I wondered what happens if the user has an unrelated stray variable > whose name happens to begin with GIT_ in her environment, but it > turns out that we cleanse them in test-lib.sh fairly early, so that > would be fine. You need to tighten your "grep" pattern, though. OK -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
