On Fri, Dec 04, 2015 at 12:05:52PM -0800, Junio C Hamano wrote: > > This probably _does_ trigger setup_git_env() when it was not otherwise > > called, and it will back to looking at ".git/config" for the repo-level > > config. That may fail to find the file if we are in a bare repository, > > or a subdirectory of the working tree. IOW, I suspect this: > > > > git init --bare foo.git > > cd foo.git > > git config credential.helper cache > > git config credentialcache.ignoreSIGHUP true ;# goes into local config > > git fetch https://example.com/foo.git > > > > may fail to respect the ignoreSIGHUP option. > > > > I guess the solution would be to setup_git_director_gently() in the > > daemon process. > > So I guess I did notice the right breakage ;-) > > At least, this won't be a regression but "a new feature initially > shipped with a broken corner case", so a follow-up fix is welcome, > but not a big deal that I've already merged it to 'master'.
Yeah, agreed on all counts. Thanks for noticing. I suspect in practice is a pretty rare corner case, but I will leave it to those who are interested in the feature to do the fixup. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
