On Wed, Nov 25, 2015 at 03:10:18PM +0100, René Scharfe wrote: > Fix that by doing the comparison using strcmp() and only after the > branch name is extracted. This way neither too less nor too many > characters are checked. While at it call strchrnul() to find the end > of the branch name instead of open-coding it. > > Helped-by: Jeff King <p...@peff.net> > Signed-off-by: Rene Scharfe <l....@web.de> > --- > We can be more careful when parsing -- or avoid parsing and backtrack > if we found "HEAD" after all. The latter is simpler, and string > parsing is tricky enough that we better take such opportunities to > simplify the code..
Yeah, I think this is nicer. We end up allocating either way anyway, so the only extra effort is copy the string. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
