[PATCH 1/5] submodule-config: keep submodule groups around

[Stefan Beller]

We need to query the groups in a later patch.

Signed-off-by: Stefan Beller <sbel...@google.com>
---
 submodule-config.c | 14 ++++++++++++++
 submodule-config.h |  2 ++
 2 files changed, 16 insertions(+)

diff --git a/submodule-config.c b/submodule-config.c
index a32259e..f44ce20 100644
--- a/submodule-config.c
+++ b/submodule-config.c
@@ -60,6 +60,7 @@ static void free_one_config(struct submodule_entry *entry)
 {
        free((void *) entry->config->path);
        free((void *) entry->config->name);
+       free((void *) entry->config->groups);
        free(entry->config);
 }
 
@@ -182,6 +183,8 @@ static struct submodule *lookup_or_create_by_name(struct 
submodule_cache *cache,
        submodule->path = NULL;
        submodule->url = NULL;
        submodule->update = NULL;
+       submodule->groups = xmalloc(sizeof(*submodule->groups));
+       string_list_init(submodule->groups, 1);
        submodule->fetch_recurse = RECURSE_SUBMODULES_NONE;
        submodule->ignore = NULL;
 
@@ -324,6 +327,17 @@ static int parse_specific_submodule_config(const char 
*subsection, int subsectio
                        free((void *) submodule->update);
                        submodule->update = xstrdup(value);
                }
+       } else if (!strcmp(key, "groups")) {
+               if (!value)
+                       ret = config_error_nonbool(var);
+               else if (!me->overwrite && submodule->groups)
+                       warn_multiple_config(me->commit_sha1, submodule->name,
+                                            "groups");
+               else {
+                       string_list_clear(submodule->groups, 0);
+                       string_list_split(submodule->groups, value, ',', -1);
+                       string_list_sort(submodule->groups);
+               }
        }
 
        return ret;
diff --git a/submodule-config.h b/submodule-config.h
index d9bbf9a..7fc21e1 100644
--- a/submodule-config.h
+++ b/submodule-config.h
@@ -3,6 +3,7 @@
 
 #include "hashmap.h"
 #include "strbuf.h"
+#include "string-list.h"
 
 /*
  * Submodule entry containing the information about a certain submodule
@@ -17,6 +18,7 @@ struct submodule {
        const char *update;
        /* the sha1 blob id of the responsible .gitmodules file */
        unsigned char gitmodules_sha1[20];
+       struct string_list *groups;
 };
 
 int parse_fetch_recurse_submodules_arg(const char *opt, const char *arg);
-- 
2.6.1.261.g0d9c4c1

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html