On Tue, 2015-11-03 at 08:40 +0100, Michael Haggerty wrote: > + * extras and skip must be sorted lists of reference names. Either one > + * can be NULL, signifying the empty list. > + */
My version had: "skip can be NULL; extras cannot." The first thing that function does is: string_list_find_insert_index(extras, dirname, 0) And that crashes when extras is null. So I think my version is correct here. Other than that, I've reviewed both the patches themselves and the overall diff and everything looks good to me. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
