On Sun, Oct 25, 2015 at 5:48 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote: > On Sat, Oct 24, 2015 at 10:42 AM, Karthik Nayak <karthik....@gmail.com> wrote: >> In ref-filter.c the comparison of refs while sorting is handled by >> cmp_ref_sorting() function. When sorting as per numerical values >> (e.g. --sort=objectsize) there is no fallback comparison when both refs >> hold the same value. This can cause unexpected results as pointed out >> by Johannes Sixt ($gmane/280117). > > Please make the commit message self-contained by describing the > "unexpected results" here rather than directing readers to chase down > the information elsewhere themselves. >
Will do. >> Hence, fallback to alphabetical comparison based on the refname whenever >> the other criterion is equal. Fix the test in t3203 in this regard. >> >> Signed-off-by: Karthik Nayak <karthik....@gmail.com> > > It would not be amiss to add a Reported-by: to credit j6t. > Definitely. Thanks for the quick review :) -- Regards, Karthik Nayak -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
