Eric Sunshine <sunsh...@sunshineco.com> writes: > With this in mind, my > question was also indirectly asking whether there was sufficient > justification of the long-term cost of a --count-lines option. The > argument that --count-lines would help test a proposed > strbuf_count_lines() likely does not outweigh that cost.
I agree. If we expect users to call --count-lines outside rebase-interactive.sh and our own tests, then the actual use should be justified in the commit message. If not, then at least the --count-lines option should be hidden and not documented in the public doc. But I agree that introducing test-strbuf would be even better. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
