On 12 Oct 2015, at 12:37, Sebastian Schuberth <sschube...@gmail.com> wrote:
> On Mon, Oct 12, 2015 at 7:12 PM, Lars Schneider > <larsxschnei...@gmail.com> wrote: > >>>> +install: make configure && ./configure >>>> + >>>> +before_script: make >>>> + >>>> +script: make --quiet test >>> >>> Semantically, it does not seem correct to me that configuarion goes to the >>> install step. As "make test" will build git anyway, I'd instead propose to >>> get rid of "install" and just say: >>> >>> before_script: make configure && ./configure >>> >>> script: make --quiet test >> >> I understand your point. I did this to make the "make" logs easily >> accessible (no option "--quite"). By default Travis CI automatically >> collapses the logs from all stages prior to the "script" stage. You can >> uncollapse these logs by clicking on the little triangle on the left border >> of the log. Therefore the "make" logs are available without noise. > > To make this more clear, I guess what you're referring to is the > visual difference between [1] and [2], correct? correct! > >> Do you see value in "make" logs? >> >> If yes then we could also do: >> before_script: make configure && ./configure && make > > Reading through Travis' docs [3] again, "before_script" is documented > to "return a non-zero exit code, the build is errored and stops > immediately", while "script" is documented as "returns a non-zero exit > code, the build is failed, but continues to run before being marked as > failed". As it does not make much sense to continue the build or even > start testing if the build failed, maybe it's indeed best to do: > > before_script: make configure && ./configure && make > > script: make --quiet test Ok, then I will make it so :-) Thanks, Lars-- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
