On Thu, Oct 8, 2015 at 5:57 PM, Matthieu Moy <[email protected]> wrote: >> + unsigned int nobracket = 0; >> + >> + if (!strcmp(valp, ",nobracket")) >> + nobracket = 1; > > The code to parse comma-separated values is different here and > elsewhere. I'd rather have the same code (possibly factored into a > helper function), both to get consistent behavior (you're not allowing > %(upstream:nobracket,track) for example, right?) and consistent code. >
Speaking of comma-separated values, the only other place we use that is in the align atom. Also I find this very specific to get a function out of. Somehow I think this is the simplest way to go about this. -- Regards, Karthik Nayak -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
