Dennis Kaarsemaker <den...@kaarsemaker.net> writes: > On Mon, Sep 28, 2015 at 06:02:18PM -0400, David Turner wrote: >> Add tests for the database backend. >> >> Signed-off-by: David Turner <dtur...@twopensource.com> >> --- >> t/t1460-refs-be-db.sh | 1103 >> ++++++++++++++++++++++++++++++++++++++++++ >> t/t1470-refs-be-db-reflog.sh | 353 ++++++++++++++ >> 2 files changed, 1456 insertions(+) >> create mode 100755 t/t1460-refs-be-db.sh >> create mode 100755 t/t1470-refs-be-db-reflog.sh > > These break 'make test' on builds without the db backend. Maybe squash > in something like the following: > > diff --git a/t/t1460-refs-be-db.sh b/t/t1460-refs-be-db.sh > index f13b0f0..c8222ed 100755 > --- a/t/t1460-refs-be-db.sh > +++ b/t/t1460-refs-be-db.sh > @@ -9,6 +9,11 @@ test_description='Test lmdb refs backend' > TEST_NO_CREATE_REPO=1 > . ./test-lib.sh > > +if ! test -e ../../test-refs-be-lmdb; then > + skip_all="Skipping lmdb refs backend tests, lmdb backend not built" > + test_done > +fi
The idea is sound, but $TRASH_DIRECTORY (i.e. $(cwd) there) is not necessarily two subdirectories down from the build repository root (cf. --root=<there> parameter to the test scripts), so you need to account for that. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
