On 04 Oct 2015, at 11:23, Junio C Hamano <gits...@pobox.com> wrote:

> larsxschnei...@gmail.com writes:
> 
>> +            if test_have_prereq CYGWIN; then
>> +                    : # NOOP
>> +            elif test_have_prereq DARWIN; then
>> +                    stat -f %Sp text | egrep ^-r-- &&
>> +                    stat -f %Sp text+x | egrep ^-r-x
>> +            else
>>                      stat --format=%A text | egrep ^-r-- &&
>>                      stat --format=%A text+x | egrep ^-r-x
>>              fi
> 
> Not a new problem but why do we need "stat" here?
> 
> Shouldn't "test -r", "! test -x", and their usual friends be
> sufficient for the purpose of the test and are more portable?

Good question. The stat call was introduced with df9c545 by Pete Wyckoff.
@Pete, @Luke: Are you aware of any particular reason for stat?

Thanks,
Lars
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to