Lars Wendler <polynomia...@gentoo.org> writes: > It seems to me that there is a size limit, after cutting down the patch > to ~16K, sending started to work. I cut it twice, once by removing lines > from the head and once from the bottom, in both cases at the size of > around 16K I could send the patch. > > See also original report: > http://permalink.gmane.org/gmane.comp.version-control.git/274569 > > Reported-by: Juston Li <juston.h...@gmail.com> > Tested-by: Markos Chandras <hwoar...@gentoo.org> > Signed-off-by: Lars Wendler <polynomia...@gentoo.org> > --- > git-send-email.perl | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/git-send-email.perl b/git-send-email.perl > index e3ff44b..e907e0ea 100755 > --- a/git-send-email.perl > +++ b/git-send-email.perl > @@ -1365,7 +1365,11 @@ Message-Id: $message_id > $smtp->mail( $raw_from ) or die $smtp->message; > $smtp->to( @recipients ) or die $smtp->message; > $smtp->data or die $smtp->message; > - $smtp->datasend("$header\n$message") or die $smtp->message; > + $smtp->datasend("$header\n") or die $smtp->message; > + my @lines = split /^/, $message; > + foreach my $line (@lines) { > + $smtp->datasend("$line") or die $smtp->message; > + }
Thanks. One and a half comments. * If 16k is the limit, and smtp payload line limit is much much shorter than that, is it sensible to send data line by line? * Has this been reported to Net::Cmd::datasend() upstream? > $smtp->dataend() or die $smtp->message; > $smtp->code =~ /250|200/ or die "Failed to send > $subject\n".$smtp->message; > } -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
