On 03 Sep 2015, at 22:18, Junio C Hamano <gits...@pobox.com> wrote: > Lars Schneider <larsxschnei...@gmail.com> writes: > >> On 03 Sep 2015, at 21:55, Luke Diamand <l...@diamand.org> wrote: >> >>> On 03/09/15 17:35, larsxschnei...@gmail.com wrote: >>>> From: Lars Schneider <larsxschnei...@gmail.com> >>>> >>> >>> I think this commit may need some explanation! >> >> The functions “gitConfig” and “gitConfigBool” are almost >> identical. Make “gitConfig” more generic by adding an optional type >> specifier. Use the type specifier “—bool” with “gitConfig” to >> implement “gitConfigBool. This prepares the implementation of other >> type specifiers such as “—int”. > > OK. > >> OK? > > Not really ;-). The point of Luke's message is that all of the > above belong to the log message, I think. Right, it is my intention to add this as commit message. I just wanted to check upfront if the message is what he expects.
That leads me to a general question: In case I agree with a reviewer. What is the more appropriate action? A response like the one above or a new role that includes the change right away? I don’t want to spam the list with lots of tiny changes… Thanks!-- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
