On Wed, Sep 02, 2015 at 10:41:34AM -0700, Junio C Hamano wrote:

> Jeff King <p...@peff.net> writes:
> 
> > +   /* historical alias */
> > +   if (!strcmp(format, "local"))
> > +           format = "default-local";
> > +
> > +   mode->type = parse_date_type(format, &p);
> > +   mode->local = 0;
> > +
> > +   if (skip_prefix(p, "-local", &p)) {
> > +           if (mode->type == DATE_RELATIVE)
> > +                   die("relative-local date format is nonsensical");
> > +           mode->local = 1;
> > +   }
> 
> I notice that we give something funny like this:
> 
>     $ git show --date=short-locale
>     fatal: unknown date-mode modifier: e

Yeah, that's not ideal.

> What is the intention here?  In other words, what kind of things can
> plausibly follow "--date=short-local" in enhanced versions of Git in
> the future?  "--date=short-local:some other magic"?

I had assumed it would be "short-local-othermagic", since ":" is already
the separator for "format:". But I admit I have no idea what other
modifiers would be interesting.

I think the error message would be a lot nicer if we indicate that "-"
is syntactically interesting, and say:

  fatal: unknown date-mode modifier: locale

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to