On Tue, Sep 1, 2015 at 6:41 PM, Matthieu Moy <[email protected]> wrote: > Karthik Nayak <[email protected]> writes: > >> Like this: >> >> else if (skip_prefix(name, "align", &valp)) { >> struct align *align = &v->u.align; >> struct strbuf **s; >> >> if (valp[0] != ':') >> die(_("format: usage %%(align:<width>,<position>)")); >> else >> valp++; >> ...... >> ........ >> } > > Checking the string's correctness as you read it seems good to me, yes. > > But as you say, you should make this a bit more generic, for example by > putting your "if/else" in a helper function, that other atoms could use.
Okay then, I'll keep that in mind :) -- Regards, Karthik Nayak -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
