On Fri, Aug 28, 2015 at 3:09 AM, Johannes Schindelin <johannes.schinde...@gmx.de> wrote: > Hi Stefan, > > On 2015-08-28 03:14, Stefan Beller wrote: > >> Stefan Beller (9): >> submodule: implement `module_list` as a builtin helper >> submodule: implement `module_name` as a builtin helper >> submodule: implement `module_clone` as a builtin helper > > Another thing that just hit me: is there any specific reason why the > underscore? I think we prefer dashes for subcommands (think: cherry-pick) and > maybe we want to do the same for subsubcommands... > > Ciao, > Dscho >
Junio wrote on Aug 3rd: >>> $ git submodule--helper module_list >> >> Why would you use an underscore in here as opposed to a dash? > > Simply because the diff would be easier to read; the callers used to > call module_list shell function, now they call the subcommand with the > same name of submodule--helper. I mean no user is expected to use the submodule--helper functions directly and we want to get rid of them eventually anyway (once the whole git-submodule.sh is rewritten in C we can just call the C functions instead of calling out to helpers) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
