On Fri, Jul 31, 2015 at 6:02 PM, Junio C Hamano <gits...@pobox.com> wrote:
> Stefan Beller <sbel...@google.com> writes:
>
>> -module_list()
>> +module_list_shell()
>> {
>> eval "set $(git rev-parse --sq --prefix "$wt_prefix" -- "$@")"
>> (
>> @@ -187,6 +187,29 @@ module_list()
>> '
>> }
>>
>> +module_list()
>> +{
>> + # call both the old and new code
>> + module_list_shell $@ >/u/git_submodule_module_list_shell
>> 2>/u/git_submodule_module_list_shell2
>> + git submodule--helper --module_list $@ >/u/git_submodule_module_list
>> 2>/u/git_submodule_module_list2
>
> You seem to be discarding the double-quote around $@ in both of
> these two places. Intended?
No, not at all. This was a bit sloppy.
This patch was rather showing off how I intend to test the previous patch.
The idea came from a talk[1] at oscon which presented refactoring code with
this differential strategy (except that they used it on a larger code base and
collected the diffs between the new and old code for a while in production
instead of just relying on the test suite passing).
[1] http://www.oscon.com/open-source-2015/public/schedule/detail/41888
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
