[PATCH 3/4] get_remote_group(): eliminate superfluous call to strcspn()

[Michael Haggerty]

There is no need to call it if value is the empty string. This also
eliminates code duplication.

Signed-off-by: Michael Haggerty <mhag...@alum.mit.edu>
---
 builtin/fetch.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/builtin/fetch.c b/builtin/fetch.c
index d0d267b..bd945d0 100644
--- a/builtin/fetch.c
+++ b/builtin/fetch.c
@@ -978,13 +978,13 @@ static int get_remote_group(const char *key, const char 
*value, void *priv)
        if (starts_with(key, "remotes.") &&
                        !strcmp(key + 8, g->name)) {
                /* split list by white space */
-               size_t wordlen = strcspn(value, " \t\n");
                while (*value) {
+                       size_t wordlen = strcspn(value, " \t\n");
+
                        if (wordlen >= 1)
                                string_list_append(g->list,
                                                   xstrndup(value, wordlen));
                        value += wordlen + (value[wordlen] != '\0');
-                       wordlen = strcspn(value, " \t\n");
                }
        }
 
-- 
2.4.6

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html