On Sat, Jul 25, 2015 at 3:16 AM, Junio C Hamano <gits...@pobox.com> wrote:
> Karthik Nayak <karthik....@gmail.com> writes:
>
>> Make color which was considered as an atom, to use
>> ref_formatting_state and act as a pseudo atom. This allows
>> interchangeability between 'align' and 'color'.
>>
>> Helped-by: Junio C Hamano <gits...@pobox.com>
>> Mentored-by: Christian Couder <christian.cou...@gmail.com>
>> Mentored-by: Matthieu Moy <matthieu....@grenoble-inp.fr>
>> Signed-off-by: Karthik Nayak <karthik....@gmail.com>
>> ---
>
> I think 1/10 and 2/10 are the other way around.  Preferably, these
> would be three patches, in this order:
>
>  (1) prepare the "formatting state" and pass it around; no other
>      code change.
>
>  (2) have "color" use that facility.
>
>  (3) add a new feature using that facility.
>
> The first two may want to be combined into a single patch, if it
> does not make the patch too noisy.
>

Ill reverse the patches and merge the first two as you suggested.
Thanks

-- 
Regards,
Karthik Nayak
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to