Karthik Nayak <karthik....@gmail.com> writes:
> + strtoul_ui(valp, 10, &ref->align_value);
> + if (ref->align_value < 1)
> + die(_("Value should be greater than zero"));
You're not checking the return value of strtoul_ui, which returns -1
before assigning align_value if the value can't be parsed. As a result,
you're testing an undefined value in the 'if' statement in this case.
You should test the return value and issue a distinct error message in
this case like
if (strtoul_ui(valp, 10, &ref->align_value))
die(_("positive integer expected after ':' in align:%u\n",
ref_align_value));
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
