Matthieu Moy <matthieu....@grenoble-inp.fr> writes
> > + my $commentrgx=qr/\((?:[^)]*)\)/;
> > + my $quotergx=qr/"(?:[^\"\\]|\\.)*"/;
> > + my $wordrgx=qr/(?:[^]["\s()<>:;@\\,.]|\\.)+/;
>
> Spaces around = please.
> ...
> > + foreach my $token (@tokens) {
> > + if ($token =~ /^[,;]$/) {
>
> Here and below: you're indenting with a 4-column offset, it should be 8.
Should have spent more time on the form... Thanks
> The code below is a bit hard to read (I'm neither fluent in Perl nor in
> the RFC ...). A few more comments would help. A few examples below (it's
> up to you to integrate them or not).
Ok, I'll add comments for the hardest parts.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
