Matthieu Moy <matthieu....@grenoble-inp.fr> writes:

> Karthik Nayak <karthik....@gmail.com> writes:
>
>> +    filter_refs(&array, FILTER_REFS_ALL | FILTER_REFS_INCLUDE_BROKEN, 
>> &filter);
>
> I think it is more common to have options at the end, so I'd write it as
>
> filter_refs(&array, &filter, FILTER_REFS_ALL | FILTER_REFS_INCLUDE_BROKEN);
>
> (changing the declaration too, obviously)

Good point.

>
> I really like the way cmd_for_each_ref looks like now.

Likewise.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to