Please, don't top-post on this list. Louis-Alexandre Stuber <stub...@ensimag.grenoble-inp.fr> writes:
> Thank you for the feedback. We are trying to apply all of your suggestions, > but we would prefer to rebase the history before doing some of them (like > renaming variables). > > About the BISECT_OLDNEWMODE file: The current implementation changes almost > nothing to revision.c. We thought it was better, even if it needs a new file. > The code for bisect uses BISECT_TERMS because 3 states are > possible: 'bad/good mode', 'old/new mode', or 'no bisection started' > (if BISECT_TERMS doesn't exist). I don't think it's the main reason. The point is to make the code generic: once the bisection has started and the terms are chosen, the possible states for a commit are not really bad/good or old/new, but 'first line in BISECT_TERMS/second line in BISECT_TERMS'. > But the other files (like revision.c) don't need all these > informations, so we thought it would be good to check if a file exists > instead of reusing BISECT_TERMS, which would require reading its > content. > > ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- > De: "Christian Couder" <christian.cou...@gmail.com> > ... -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
