Guillaume Pagès <guillaume.pa...@ensimag.grenoble-inp.fr> writes:

> +     if (!fclose(fp))
> +             strbuf_detach(&buf, NULL);
> +     else
> +             strbuf_release(&buf);

Why these two cases? Aren't you leaking the buffer when calling
strbuf_detach and ignoring its return value?

(In general, there's not much to do when fclose fails actually)

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to