Remi Galan Alfonso <remi.galan-alfo...@ensimag.grenoble-inp.fr> writes:
> Junio C Hamano <gits...@pobox.com> writes: >> Is this sufficient? > >> If you are going to do something in 2/2 that relies on the format of >> this line being correct (as opposed to "noop" or "#" that can have >> any garbage on the remainder of the line), wouldn't you want to at >> least check $sha1 is sensible? > > That's also something that I was wondering, I wrote about it in the > 0/2 part of this patch, I wanted some opinion about it. Ideally, I think we should do a sanity check before starting the rebase, and error out if we encounter an invalid command, a command that should be followed by a valid sha1 and does not, ... But currently, we do the verification while applying commands, and I don't think there's anything really helpful to do if we encounter a "drop this-is-not-a-sha1" command. So, IMHO, why not do this check, but I'm not sure it will actually help much. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
