On Sun, May 31, 2015 at 11:16:45AM -0700, Jim Hill wrote: > Make strbuf_read not try to do read_in_full's job too. If xread returns > less than was requested it can be either eof or an interrupted read. If > read_in_full returns less than was requested, it's eof. Use read_in_full > to detect eof and not iterate when eof has been seen.
I think this makes sense. I somehow had to read this over several times to understand that the main point is not the cleanup, but rather the space savings from not doing an extra strbuf_grow. Perhaps it is because the main idea is mentioned only in the subject. Or perhaps I was just being dense. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
