On 05/14/2015 07:00 PM, Junio C Hamano wrote: > Michael Haggerty <mhag...@alum.mit.edu> writes: > >>> But there is a i18n markings test, for which test-i18ngrep was invented for. >> >> Thanks for the info. I wasn't aware of that facility. >> >> So if I understand correctly, s/grep/test_i18ngrep/ will address your >> concern? That's fine with me. > > Thinking about it again, should these messages ever be translated, > or are they plumbing messages that should never get translated? > > If the latter, then 'grep' is the right thing to do; in fact, it > would be a bug in the test if we used test_i18ngrep. > > Side note: besides, I think gettext-poison tests have bitrot > and are no longer very useful (if they ever were, that is).
I don't really know how to decide which messages should be translatable and which not. Obviously 'update-ref' is a plumbing command, but these same error messages can be emitted by any reference transaction, such as when a push fails, in which case they are visible to the user. Some other errors that can result from ref transaction failures are tested in t1400 with 'grep'. I think using 'grep' is OK for now, and if they are internationalized in the future the breakage will be pretty obvious and straightforward to fix. Michael -- Michael Haggerty mhag...@alum.mit.edu -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
