Re: [PATCH] compat/mingw: stubs for getpgid() and tcgetpgrp()

[Johannes Sixt]

Am 15.04.2015 um 20:48 schrieb Junio C Hamano:
The patch should do for now, but I suspect that it may give us a
better abstraction to make the "is_foreground_fd(int fd)" or even
"is_foreground(void)" the public API that would be implemented as
        int we_are_in_the_foreground(void)
         {
                return getpgid(0) == tcgetpgrp(fileno(stderr));
        }

in POSIX and Windows can implement entirely differently.

Thoughts?

IMHO, this level of abstraction goes too far. It may be that I am not 
familiar with process groups, and I find the implementation of 
is_foreground_fd() in progress.c close to where it's used quite 
educating and enlightening. Hiding a similar implementation miles away 
in cache.h and/or compat/ would not pay off for me.

-- Hannes

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html