On Mon, Apr 13, 2015 at 2:43 PM, Matthieu Moy <matthieu....@grenoble-inp.fr> wrote: > Paul Tan <pyoka...@gmail.com> writes: > >> As such, implement a simpler function xdg_config_home() for constructing >> the XDG base dir spec configuration file path. This function, together >> with expand_user_path(), can replace all uses of home_config_paths(). > > Indeed. The code looks much better after your patch series than before. > > I agree with Dscho's remark that "fn" sounds like "function" more than > "filename". Perhaps just "name" would be better.
I'd go with fname but that's just bikeshedding now. > > Anyway, the series is > > Reviewed-by: Matthieu Moy <matthieu....@imag.fr> and Reviewed-by: Stefan Beller <sbel...@google.com> > > -- > Matthieu Moy > http://www-verimag.imag.fr/~moy/ > -- > To unsubscribe from this list: send the line "unsubscribe git" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html