On Fri, Apr 03, 2015 at 02:02:15AM +0200, Torsten Bögershausen wrote: > But not this one: > ./git fetch-pack --diag-url > ssh://git.kernel.org:/pub/scm/linux/kernel/git/mchehab/v4l-dvb.git > Diag: url=ssh://git.kernel.org:/pub/scm/linux/kernel/git/mchehab/v4l-dvb.git > Diag: protocol=ssh > Diag: userandhost=git.kernel.org: > Diag: port=NONE > > > Spontaneously I would say that a trailing ':' at the end of a hostname in the > ssh:// scheme > can be safely ignored, what do you think ?
I think instead of ignoring it we can just produce an error. The user might have meant to specify a port, but forgotten. I've done similar things before. I generally prefer being a bit stricter and giving helpful error messages rather than trying to intuit what the user meant. The user is always going to come up with a new way to break the code. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
signature.asc
Description: Digital signature
