Kenny Lee Sin Cheong <kenny.le...@gmail.com> writes: > If I'm understanding correctly, the problem of checking revisions before > arg is that an option fed to handle_revision_arg() might die() before getting > checked as an option in cases where a file with the same name exists? > > But doesn't verify_non_filename() already return silently if arg begins > with "-"? It die() only after making that check. > > If an option with ".." in it such as -$opt..ion is really given to > handle_revision_arg() then verify_non_filename should not be a problem.
Yes, but should we be relying on that behaviour? The special casing to assume that no sane person would name a file starting with a dash is what I find somewhat disturbing. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
