Similarly to the "merge doc and code", I personally prefer seeing code and tests in the same patch.
Actually, my preference goes for a first patch that introduces the tests with test_expect_failure for things that are not yet implemented (and you can check that tests do not pass yet before you code), and then the patch introducing the feature doing -test_expect_failure +test_expect_success which documents quite clearly and concisely that you just made the feature work. Paul Tan <pyoka...@gmail.com> writes: > +test_expect_success 'if custom XDG_CONFIG_HOME credentials file > + ~/xdg/git/credentials exists, it will only be written to; > + ~/.config/git/credentials and ~/.git-credentials will not be > + created' ' > + test_when_finished "rm -f $HOME/xdg/git/credentials" && > + test -s "$HOME/xdg/git/credentials" && > + test_path_is_missing "$HOME/.config/git/credentials" > + test_path_is_missing "$HOME/.git-credentials" > +' Broken &&-chain. That is a real issue that must be fixed. > +test_expect_success 'get: return credentials from home file if xdg files are > unreadable' ' "files are" -> "file is", no? > +' > + > + > +test_expect_success 'erase: erase matching credentials from both xdg and > home files' ' Double blank line. On overall, except the broken &&-chain above, the whole series looks good. Feel free to ignore my other nitpicks if you prefer. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
