On Tue, Mar 3, 2015 at 3:43 AM, Michael Haggerty <mhag...@alum.mit.edu> wrote: > This is v3 of the patch series. Thanks to Junio for his comments > about v2 [1]; I think this version addresses all of his points. > > Changes since v2: > > * Introduce a temporary in "struct ref_lock: delete the force_write > member" to make a complicated boolean expression easier to > understand. > > * Split the documentation of options for "reflog expire" and "reflog > delete", and make another couple tweaks to the "reflog" > documentation. > > * Add a NEEDSWORK comment suggesting that the "reflog" command should > use parse_options() to process its command line. > > [1] http://thread.gmane.org/gmane.comp.version-control.git/264586
The whole series is Reviewed-by: Stefan Beller <sbel...@google.com> Thanks for adjusting the commit from me to fit in better into the series. Thanks, Stefan > > Michael Haggerty (6): > write_ref_sha1(): remove check for lock == NULL > write_ref_sha1(): Move write elision test to callers > lock_ref_sha1_basic(): do not set force_write for missing references > reflog: improve and update documentation > reflog_expire(): ignore --updateref for symbolic references > reflog_expire(): never update a reference to null_sha1 > > Stefan Beller (1): > struct ref_lock: delete the force_write member > > Documentation/git-reflog.txt | 144 > ++++++++++++++++++++++++++----------------- > builtin/reflog.c | 9 +-- > refs.c | 65 ++++++++++--------- > 3 files changed, 126 insertions(+), 92 deletions(-) > > -- > 2.1.4 > -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
