On Sun, Feb 15, 2015 at 9:47 PM, Jeff King <p...@peff.net> wrote: > When the "push_default" flag was originally added, it was > made globally visible to all code. This might have been > useful if other commands or library calls ended up depending > on it, but as it turns out, only builtin/push.c cares. > ... > Signed-off-by: Jeff King <p...@peff.net> > --- > We know this is safe because no other callers needed tweaked when the > variable went out of scope. :) It would only be a bad idea if we > were planning on having other code in the future depend on push_default > (e.g., the code in remote.c to find the push destination). But it does > not seem to have needed that in the intervening years, so it's probably > fine to do this cleanup now.
Yay. Great minds think alike ;-) "It definitely smells wrong to touch environment.c and cache.h" was my first reaction to the "follow-tags config" patch, and I really think this shows the right way forward. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
