Add test cases documenting the current behavior when trying to
add/append/edit empty notes. This is in preparation for adding
--allow-empty; to allow empty notes to be stored.
Improved-by: Eric Sunshine <sunsh...@sunshineco.com>
Signed-off-by: Johan Herland <jo...@herland.net>
---
t/t3312-notes-empty.sh | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 48 insertions(+)
create mode 100755 t/t3312-notes-empty.sh
diff --git a/t/t3312-notes-empty.sh b/t/t3312-notes-empty.sh
new file mode 100755
index 0000000..44074f6
--- /dev/null
+++ b/t/t3312-notes-empty.sh
@@ -0,0 +1,48 @@
+#!/bin/sh
+
+test_description='Test adding/editing of empty notes'
+. ./test-lib.sh
+
+write_script fake_editor <<\EOF
+ echo "$MSG" >"$1"
+EOF
+GIT_EDITOR=./fake_editor
+export GIT_EDITOR
+
+test_expect_success 'setup' '
+ test_commit one &&
+ git log -1 >expect_missing &&
+ empty_blob=$(git hash-object -w /dev/null)
+'
+
+cleanup_notes() {
+ git update-ref -d refs/notes/commits
+}
+
+verify_missing() {
+ git log -1 > actual &&
+ test_cmp expect_missing actual &&
+ ! git notes list HEAD
+}
+
+for cmd in \
+ 'add' \
+ 'add -F /dev/null' \
+ 'add -m ""' \
+ 'add -c "$empty_blob"' \
+ 'add -C "$empty_blob"' \
+ 'append' \
+ 'append -F /dev/null' \
+ 'append -m ""' \
+ 'append -c "$empty_blob"' \
+ 'append -C "$empty_blob"' \
+ 'edit'
+do
+ test_expect_success "'git notes $cmd' removes empty note" "
+ cleanup_notes &&
+ MSG= git notes $cmd &&
+ verify_missing
+ "
+done
+
+test_done
--
2.0.0.rc4.501.gdaf83ca
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
