On Wed, Nov 5, 2014 at 5:10 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote:

[...]

> write_script() would allow you to drop the #!/bin/sh and chmod lines.

[...]

> Rather than hard-coding this output, generating it would make the test
> script less fragile:
>
>     git log -1 >expect_missing

[...]

> Each -c/-C case fails for me when trying to read $empty_object. For example:
>
> fatal: Failed to read object 'e69de29bb2d1d6434b8b29ae775ad8c2e48c5391'.
> not ok 5 - 'git notes add -c "$empty_blob"' removes empty note

These are all fixed in the re-roll.

Thanks for the feedback!


...Johan

-- 
Johan Herland, <jo...@herland.net>
www.herland.net
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to