On Mon, Sep 22, 2014 at 4:50 PM, Junio C Hamano <gits...@pobox.com> wrote: > Eric Sunshine <sunsh...@sunshineco.com> writes: > >> however, the solution in this patch allows us drop a couple strlen()s in >> favor of sizeof()s. > > It is actually not a very good justification when you know you care > about the length of the string. A decent compiler ought to know the > length of a constant string can be computed at the compilation time.
Indeed, which is why I mentioned this only in the commentary rather than the commit message; but I was also thinking of some of the less-than-decent compilers with which git is sometimes built. > Let's at least not do that part of the change. I don't have strong feelings about it. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
