On Wed, Sep 17, 2014 at 3:11 AM, Jeff King <p...@peff.net> wrote: > Would we want to call it from external C commands, too? For the most > part, git.c is the entry point for running git commands, and any > sanitizing it does will be inherited by sub-commands. But it _is_ still > legal to call dashed commands individually, and even required in some > cases (e.g., git-upload-pack for ssh clients).
git-upload-pack is protected pretty well from SIGPIPE shenanigans, because its stdout all goes through write_or_die, as of cdf4fb8. We did, long ago, have some EPIPE problems with upload-pack and SSH clients, but it all predates cdf4fb8. So I think it's redundant to unblock SIGPIPE in git-upload-pack. I'll tidy up as Junio recommended, recheck the tests, and submit an updated patch shortly. --Patrick -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
