... answering to myself, the only invoker does not seem to care, so I do not mind if the fprintf/exit gets turned into die() in a follow-up patch.
Thanks. On Tue, Aug 12, 2014 at 2:38 PM, Junio C Hamano <gits...@pobox.com> wrote: > Matthieu Moy <matthieu....@grenoble-inp.fr> writes: > >> Stefan Beller <stefanbel...@gmail.com> writes: >> >>> + if (is_bare && !allow_bare) { >>> + unlink(name); >>> + fprintf(stderr, "corrupt mailbox\n"); >>> + exit(1); >>> + } >> >> Not directly related to your patch, but shouldn't this be using >> >> die(_("corrupt mailbox")); >> >> instead? > > Doesn't the exit status of mailsplit matter to its existing > invokers? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html