* Junio C Hamano ([email protected]) wrote: > > On e.g. FreeBSD 10.x, the following situation is common: > > - there's iconv implementation in libc, which has no locale_charset() > > function > > - there's GNU libiconv installed from Ports Collection > > > > Git build process > > - detects that iconv is in libc and thus -liconv is not needed for it > > - detects locale_charset in -liconv, but for some reason doesn't add it > > to CHARSET_LIB (as it would do with -lcharset if locale_charset() was > > found there instead of -liconv) > > - git doesn't build due to unresolved external locale_charset() > > > > Fix this by adding -liconv to CHARSET_LIB if locale_charset() is > > detected in this library. > > > > Signed-off-by: Dmitry Marakasov <[email protected]> > > --- > > Looks sensible; Dilyan, any comments?
Addendum: build logs before and after the fix: http://people.freebsd.org/~amdmi3/git-iconv-fail.log http://people.freebsd.org/~amdmi3/git-iconv-fixed.log -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D [email protected] ..: jabber: [email protected] http://www.amdmi3.ru -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
