Pavan Kumar Sunkara <pavan.sss1...@gmail.com> writes:
> Golang is quickly becoming one of the major programming languages.
>
> This change switches on golang syntax highlight support by default
> in gitweb rather than asking the users to do it using config files.
Looks trivially harmless ;-)
I haven't touched this part of our system, but the patch makes me
wonder if there is a way for us to _ask_ the installed 'highlight'
binary what languages it knows about. This hash is used only in
guess_file_syntax sub, and it may not be unreasonable to populate it
lazily there, or at least generate this part by parsing output from
'highlight -p' at build-install time.
> Signed-off-by: Pavan Kumar Sunkara <pavan.sss1...@gmail.com>
> ---
> gitweb/gitweb.perl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index bf7fd67..aa6fcfd 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -273,7 +273,7 @@ our %highlight_basename = (
> our %highlight_ext = (
> # main extensions, defining name of syntax;
> # see files in /usr/share/highlight/langDefs/ directory
> - (map { $_ => $_ } qw(py rb java css js tex bib xml awk bat ini spec tcl
> sql)),
> + (map { $_ => $_ } qw(py rb java go css js tex bib xml awk bat ini spec
> tcl sql)),
> # alternate extensions, see /etc/highlight/filetypes.conf
> (map { $_ => 'c' } qw(c h)),
> (map { $_ => 'sh' } qw(sh bash zsh ksh)),
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
