Jeff King <p...@peff.net> writes: > I'm happy with it either way. I almost just pulled the macro > definitions, including DIFF_FILE_VALID, out of the struct definition > completely. I see the value in having the flags near their bitfield, but > it makes the definition a bit harder to read.
Yeah, my thoughts exactly when I did those two conflicting changes. I have a slight preference "Constants go with the fields they are used in" over "fields and macros mixed together is harder to read", so let's use your patch as-is. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
