On 01/06/2014 07:21 PM, Junio C Hamano wrote: > Michael Haggerty <mhag...@alum.mit.edu> writes: > >> If safe_create_leading_directories() fails because a file along the >> path unexpectedly vanished, try again from the beginning. Try at most >> 3 times. > > As the previous step bumped it from 3 to 4 without explanation, the > above no longer reflects reality ;-)
Good catch. The increment 3 -> 4 was because the first call to rename() is optimistic, and can fail once even if there is no race. I will change the commit message of 16/17 to explain this point, and of 17/17 to match reality. > The series mostly looked sane from a cursory read. > > Will re-queue. Thanks. Michael -- Michael Haggerty mhag...@alum.mit.edu http://softwareswirl.blogspot.com/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
