Am 07.12.2013 23:23, schrieb Thomas Rast: > Karsten Blees <karsten.bl...@gmail.com> writes: > >> Extending 'struct hashmap_entry' with an int-sized member shouldn't waste >> memory on 64-bit systems. This is already documented in api-hashmap.txt, >> but needs '__attribute__((__packed__))' to work. Reduces e.g. > > You'd have to guard __attribute__((__packed__)) with some compiler > detection in git-compat-util.h though. >
Isn't that already handled? __attribute__ is already widely used (e.g. for printf formats), and platforms that don't support it define it as empty (e.g. MSVC). Or do you mean I should account for compiler-specific variants (#pragma pack...)? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
