On Mon, Sep 30, 2013 at 02:26:36PM -0700, Jonathan Nieder wrote:

> Jeff King wrote:
> 
> >                                            I think we'd be better off to
> > simply mark up the few callsites. Workarounds are here:
> >
> >   http://article.gmane.org/gmane.comp.version-control.git/230026
> 
> Yeah, that looks okay (ugly but tolerable).  It's tempting to do
> something like
> 
>       -       status_printf_ln(s, GIT_COLOR_NORMAL, "");
>       +       status_nl(s, GIT_COLOR_NORMAL);
> 
> and
> 
>       -       status_printf(s, color(WT_STATUS_HEADER, s), "");
>       +       status_start_line(s, color(WT_STATUS_HEADER, s));
> 
> to make the intent clearer.  Sane?

Yeah, I hinted at adding wrappers like this in the earlier thread but
didn't actually try it.  I think the approach is reasonable, as I doubt
the wrappers should require too much refactoring.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to